fix(rapidocr): propagate num_threads to OpenVINO backend#3666
Open
KyleFearne wants to merge 1 commit into
Open
fix(rapidocr): propagate num_threads to OpenVINO backend#3666KyleFearne wants to merge 1 commit into
KyleFearne wants to merge 1 commit into
Conversation
RapidOcrModel only set EngineConfig.onnxruntime.intra_op_num_threads, so with backend="openvino" the accelerator num_threads was dropped and OpenVINO defaulted to all physical cores per session, causing CPU oversubscription on wide multi-worker boxes with no docling-level control. Map accelerator_options.num_threads to EngineConfig.openvino.inference_num_threads as well, mirroring the ONNXRuntime fix in docling-project#3062. Signed-off-by: Kyle Fearne <kyle.fearne@gmail.com>
Contributor
|
✅ DCO Check Passed Thanks @KyleFearne, all your commits are properly signed off. 🎉 |
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
backend="openvino",AcceleratorOptions.num_threadswas ignored and eventually left unset.RapidOcrModelonly populatedEngineConfig.onnxruntime.intra_op_num_threads, neverEngineConfig.openvino.*. OpenVINO then defaults to all physical cores per session, causing CPU oversubscription on wide multi-worker hosts with no docling-level control.Map
num_threads -> EngineConfig.openvino.inference_num_threads, mirroring the ONNXRuntime fix in #3062. Added a parametrized test that asserts the thread count reaches the engine in use for both backends.Resolves #3665